Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for free MAC failure
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java
Line 171: if (!mInitialized) {
Line 172: throw new
VdcBLLException(VdcBllErrors.MAC_POOL_NOT_INITIALIZED);
Line 173: }
Line 174: internalFreeMac(mac);
Line 175: } catch (Exception ex) {
ok, how about that at the if (!mInitialized) i will set some boolean flag to
true (let's say - errorOccurred= true) - this will also be set at the catch
block (i will only log the exception there) and at the finally block i add -
if (errorOcurred) { .... } and perform audit log only if errorOcurred is true?
Line 176: log.debug("Failed to free MAC address",ex);
Line 177: log.errorFormat("Failed to free MAC address {0}.
Exception message is {1}", mac, ex.getMessage());
Line 178: AuditLogableBase logable = new AuditLogableBase();
Line 179: logable.AddCustomValue("MACAddr",mac);
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
