Greg Padgett has posted comments on this change.
Change subject: engine: cpu host feature
......................................................................
Patch Set 19: Looks good to me, but someone else must approve
(2 inline comments)
Looks good, just a couple minor comments if you happen to send another patch.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
Line 329: }
Line 330: return true;
Line 331: }
Line 332:
Line 333: public boolean isUseHostCpuFlags() {
Minor nitpick: if you do another patch, it would be good to put the new getter
and setter around line 260 with the others.
Line 334: return useHostCpuFlags;
Line 335: }
Line 336:
Line 337: public void setUseHostCpuFlags(boolean useHostCpuFlags) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1120: getRunVMOnSpecificHost().setEntity(false);
Line 1121: getRunVMOnSpecificHost().setIsChangable(false);
Line 1122:
Line 1123: getHostCpu().setEntity(false);
Line 1124: getRunVMOnSpecificHost().setIsChangable(false);
Lines 1121 and 1124 are the same--are they both needed (perhaps because of
events)? If you're doing another patch, a comment explaining this may help
unsuspecting maintainers not break it.
Line 1125:
Line 1126: getCdImage().setIsChangable(false);
Line 1127:
Line 1128: InitOSType();
--
To view, visit http://gerrit.ovirt.org/9753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
