Doron Fediuck has posted comments on this change.
Change subject: engine: template support for cpu host
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
The condition we check should be fixed to handle a case
where we can start a vm on any host and not migrate it from this host.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 75: .toString(),
getReturnValue().getCanDoActionMessages());
Line 76: }
Line 77:
Line 78: if (getParameters().getVmTemplateData().isUseHostCpuFlags()
Line 79: &&
getParameters().getVmTemplateData().getMigrationSupport() !=
MigrationSupport.PINNED_TO_HOST) {
Should be fixed to == migratable.
Line 80: return
failCanDoAction(VdcBllMessages.VM_HOSTCPU_MUST_BE_PINNED_TO_HOST);
Line 81: }
Line 82:
Line 83: return returnValue;
--
To view, visit http://gerrit.ovirt.org/10205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7da929baee0f4bb9e01ffd3d08989a7628d08743
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
