Liron Aravot has posted comments on this change.

Change subject: core: Add NetworkLinking support to OvfVm.
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 426:                 "rasd:MACAddress", _xmlNS).InnerText : "");
Line 427:         String networkName = 
node.SelectSingleNode(OvfProperties.VMD_CONNECTION, _xmlNS).InnerText;
Line 428:         if (StringUtils.isNotEmpty(networkName)) {
Line 429:             iface.setNetworkName(networkName);
Line 430:         } else {
if that's for vnic it might be irrelevant, just wrote it because we had this 
exception a while ago with network table and compensation.
Line 431:             iface.setNetworkName(null);
Line 432:         }
Line 433: 
Line 434:         XmlNode linkedNode = 
node.SelectSingleNode(OvfProperties.VMD_LINKED, _xmlNS);


--
To view, visit http://gerrit.ovirt.org/9802
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to