Omer Frenkel has posted comments on this change.
Change subject: core: [RFE] Display of both the console user and the guest user
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmConsoleDataCommand.java
Line 28: protected void executeVmCommand() {
Line 29: VM vm = getVm();
Line 30:
vm.setConsoleCurrentUserName(getParameters().getConsoleUserName());
Line 31:
Line 32: final VmDynamicDAO dao =
DbFacade.getInstance().getVmDynamicDao();
please use: runVdsCommand(VDSCommandType.UpdateVmDynamicData,..)
so it will be sync'd with monitoring updates
Line 33: dao.update(vm.getDynamicData());
Line 34:
Line 35: setSucceeded(true);
Line 36: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java
Line 50
Line 51
Line 52
Line 53
Line 54
just to be sure,
this is removed because the guest user name will be updated from vdsm?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 11: AddVmFromTemplate(2, ActionGroup.CREATE_VM,
QuotaDependency.STORAGE),
Line 12: AddVmFromScratch(3, ActionGroup.CREATE_VM, QuotaDependency.NONE),
Line 13: RemoveVm(4, ActionGroup.DELETE_VM, QuotaDependency.STORAGE),
Line 14: UpdateVm(5, ActionGroup.EDIT_VM_PROPERTIES,
QuotaDependency.VDS_GROUP),
Line 15: UpdateVmConsoleData(6, ActionGroup.EDIT_VM_PROPERTIES,
QuotaDependency.NONE),
need to think about this, if user has only "connect" but no "edit", when he
will disconnect this method will try to run but will fail
maybe it should be in the same group with connect? (see setVmTicket)
Line 16: StopVm(7, ActionGroup.VM_BASIC_OPERATIONS, QuotaDependency.BOTH),
Line 17: ShutdownVm(8, ActionGroup.VM_BASIC_OPERATIONS,
QuotaDependency.VDS_GROUP),
Line 18: ChangeDisk(9, ActionGroup.CHANGE_VM_CD, QuotaDependency.NONE),
Line 19: PauseVm(10, QuotaDependency.NONE),
--
To view, visit http://gerrit.ovirt.org/10219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5b178402b32435ceb79120ea1e411f0cc83606
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
