Moti Asayag has posted comments on this change.
Change subject: engine: Added VM NIC validator
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
very nice and easy to read/understand/maintain/...
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
Line 11: */
Line 12: public class VmNicValidator {
Line 13:
Line 14: private VmNetworkInterface nic;
Line 15:
why extra space if no javadoc for properties ?
Line 16: private String version;
Line 17:
Line 18: public VmNicValidator(VmNetworkInterface nic, String version) {
Line 19: this.nic = nic;
--
To view, visit http://gerrit.ovirt.org/10268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b5ddd5530fd1435bec471f9b07aa7858abe172
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
