Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
......................................................................
Patch Set 18: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
Line 54: }
Line 55:
Line 56: List<VmNetworkInterface> interfaces =
DbFacade.getInstance().getVmNetworkInterfaceDao()
Line 57: .getAllForVm(getParameters().getVmId());
Line 58:
please pull the next validation (next for followed by if block) into its own
method to improve readability
Line 59: // Check the destination cluster have all the networks
that the VM use
Line 60: // Checks that if the destination Cluster doesn't
support Network linking the VM doesn't have Nics with
Line 61: // unlinked Network ("no network" is allowed here,
will be blocked in RunVm)
Line 62: List<Network> networks =
DbFacade.getInstance().getNetworkDao().getAllForCluster(getParameters().getClusterId());
....................................................
Commit Message
Line 5: CommitDate: 2012-12-20 11:16:10 +0200
Line 6:
Line 7: core: add NetworkLinking to ChangeVMClusterCommand
Line 8:
Line 9: When chaning the VM Cluster-
s/chaning/changing
Line 10: if the new Cluster doesn't support NetworkLinking and the VM has Vnics
with
Line 11: 1. No network (null)- it is allowed.
Line 12: CanDoAction will be thrown when the user will try to run the vm.
Line 13: 2. Unlinked Network- canDoAction is thrown.
--
To view, visit http://gerrit.ovirt.org/9576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3dd865ccd99f23862db4f4a37aa5e816db3214
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
