Moti Asayag has posted comments on this change.
Change subject: core: create UpdateVmInterfaceVDSCommand
......................................................................
Patch Set 16: Looks good to me, approved
(1 inline comment)
2 issues here:
1. If there are no further comments - i guess deviceType is agreed.
2. inline the return value of VdsServerWrapper (just wondering what is the
motivation of having it this way)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
Line 1197: public StatusOnlyReturnForXmlRpc vmUpdateDevice(String vmId,
XmlRpcStruct device) {
Line 1198: try {
Line 1199: Map<String, Object> xmlRpcReturnValue =
Line 1200: vdsServer.vmUpdateDevice(vmId,
device.getInnerMap());
Line 1201: StatusOnlyReturnForXmlRpc wrapper = new
StatusOnlyReturnForXmlRpc(xmlRpcReturnValue);
any reason having this line split and not inline ? (except that the rest of the
file does it)
Line 1202: return wrapper;
Line 1203: } catch (UndeclaredThrowableException ute) {
Line 1204: throw new XmlRpcRunTimeException(ute);
Line 1205: }
--
To view, visit http://gerrit.ovirt.org/9669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
