Mike Kolesnik has posted comments on this change.

Change subject: engine: Process netIfaces element reported by VDSM
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 1335:         if (items.length == 0) {
Line 1336:             return null;
Line 1337:         }
Line 1338: 
Line 1339:         List<String> list = new ArrayList<String>();
Why not use just Arrays.asList?
Line 1340:         for (Object item : items) {
Line 1341:             list.add((String) item);
Line 1342:         }
Line 1343:         return list;


--
To view, visit http://gerrit.ovirt.org/10231
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b7f396efbadb4e43c67c1706eee0eca47ab9eb8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to