Allon Mureinik has posted comments on this change.
Change subject: core: support multiple concurrent disks migration
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Some minor comments about AppErrors - note that they probably apply to all four
copies of it.
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 727: ACTION_TYPE_FAILED_VM_SNAPSHOT_NOT_IN_PREVIEW=Cannot ${action}
${type} to a Snapshot that is not being previewed. Please select the correct
Snapshot to restore to: Either the one being previewed, or the one before the
preview.
Line 728: ACTION_TYPE_FAILED_FLOATING_DISK_NOT_SUPPORTED=${action} ${type} of a
floating disk is not supported.
Line 729: ACTION_TYPE_FAILED_FLOATING_DISK_NOT_SUPPORTED=Cannot ${action} a
floating ${type} (${diskAliases}). This operation is not supported.
Line 730: ACTION_TYPE_FAILED_SHAREABLE_DISK_NOT_SUPPORTED=Cannot ${action} a
shareable ${type}. This operation is not supported.
Line 731: ACTION_TYPE_FAILED_DISK_NOT_EXIST=Cannot ${action} ${type}. The
specified disk does not exist.
Didn't you remove these messages?
Line 732: ACTION_TYPE_FAILED_NO_DISKS_SPECIFIED=Cannot ${action} ${type}. No
disks have been specified.
Line 733: ACTION_TYPE_FAILED_DISK_IS_NOT_TEMPLATE_DISK=Cannot ${action}
${type}. The selected disk is not a template disk. Only template disks can be
copied.
Line 734: ACTION_TYPE_FAILED_SOURCE_AND_TARGET_SAME=Cannot ${action} ${type}.
The source and target storage domains are the same.
Line 735: ACTION_TYPE_FAILED_CANNOT_MOVE_TEMPLATE_DISK=Cannot ${action}
${type}. Template disks cannot be moved.
--
To view, visit http://gerrit.ovirt.org/10154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadcffa5748b58b1af40535b0447487dde6c2d6cb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
