Gilad Chaplik has posted comments on this change.
Change subject: Adding HostSubTab to UI for BIOS information
......................................................................
Patch Set 6: (2 inline comments)
minor comments
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBiosModel.java
Line 5: import org.ovirt.engine.ui.uicommonweb.models.EntityModel;
Line 6: import org.ovirt.engine.ui.uicompat.ConstantsManager;
Line 7:
Line 8: @SuppressWarnings("unused")
Line 9: public class HostBiosModel extends EntityModel
rename to HostBiosGeneralModel
Line 10: {
Line 11: private boolean updateUpgradeAlert;
Line 12:
Line 13: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 1464: generalModel.getRequestEditEvent().addListener(this);
Line 1465:
generalModel.getRequestGOToEventsTabEvent().addListener(this);
Line 1466: ObservableCollection<EntityModel> list = new
ObservableCollection<EntityModel>();
Line 1467: list.add(generalModel);
Line 1468: list.add(new HostBiosModel());
should be visible in gluster/virt/both?
Line 1469: list.add(new HostVmListModel());
Line 1470: list.add(new HostInterfaceListModel());
Line 1471: setHostEventListModel(new HostEventListModel());
Line 1472: list.add(getHostEventListModel());
--
To view, visit http://gerrit.ovirt.org/10115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3de1be89f0457f9fc7b9f3db741df8bce05ed704
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alexey Chub <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
