Ori Liel has posted comments on this change. Change subject: restapi: add /disks sub-collection to /storagedomain resource ......................................................................
Patch Set 2: (2 inline comments) looks great, only some missing tests .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java Line 72: assertTrue(model.isSparse()); Line 73: assertTrue(!model.isBootable()); Line 74: assertTrue(model.isPropagateErrors()); Line 75: } Line 76: Logic of matching fetched disk to the correct storage-id was not tested in this class, adding this would make the test class more complete. .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java Line 163: assertFalse(model.isSetVm()); Line 164: assertTrue(model.isSparse()); Line 165: assertTrue(!model.isBootable()); Line 166: assertTrue(model.isPropagateErrors()); Line 167: } Missing test for list() -- To view, visit http://gerrit.ovirt.org/10337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6c18e5b28e81f13b44e9431efd623a5627379a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
