Maor Lipchuk has posted comments on this change.
Change subject: core: add comments to addDiskCommand
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 272: return DbFacade.getInstance().getDiskLunMapDao();
Line 273: }
Line 274:
Line 275: /**
Line 276: * @return The ID of the storage domain where the VM's disks
reside.
Why not changed the java doc to be more informative?
Line 277: */
Line 278: private Guid getDisksStorageDomainId() {
Line 279: for (Disk disk : getVm().getDiskMap().values()) {
Line 280: if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
Line 292:
getParameters().getDiskInfo().getDiskStorageType() == DiskStorageType.IMAGE &&
Line 293: getVm() != null) {
Line 294:
Line 295: updateDisksFromDb();
Line 296: storageDomainId = getDisksStorageDomainId();
I think it's better to add empty line before the comment. IMHO it will be more
easy to read.
Line 297: // this set is done so that in case we will execute
an async task
Line 298: // the correct storage domain id will be set during
the call to the end methods
Line 299: getParameters().setStorageDomainId(storageDomainId);
Line 300: } else if (storageDomainId == null) {
Line 297: // this set is done so that in case we will execute
an async task
Line 298: // the correct storage domain id will be set during
the call to the end methods
Line 299: getParameters().setStorageDomainId(storageDomainId);
Line 300: } else if (storageDomainId == null) {
Line 301: storageDomainId = Guid.Empty;
same here
Line 302: // this set is done so that in case we will execute
an async task
Line 303: // the correct storage domain id will be set during
the call to the end methods
Line 304: getParameters().setStorageDomainId(storageDomainId);
Line 305: }
--
To view, visit http://gerrit.ovirt.org/10344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I818e38c98aaa2ed76239e4303df7d1bb20d3628b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
