Michael Pasternak has posted comments on this change.
Change subject: API: Adding support for external events
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
please add tests
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1258: body:
Line 1259: parameterType: Event
Line 1260: signatures:
Line 1261: - mandatoryArguments: {event.description: 'xs:string',
event.severity: 'xs:string', event.origin: 'xs:string', event.customId:
'xs:int'}
Line 1262: optionalArguments:{event.floodRate: 'xs:int', event.host.id:
'xs:string',event.user.id: 'xs:string',event.vm.id:
'xs:string',event.storageDomain.id: 'xs:string',event.template.id:
'xs:string',event.cluster.id: 'xs:string',event.dataCenter.id: 'xs:string',}
name should be in xml style: flood_rate and not floodRate, same for the
storageDomain, dataCenter
Line 1263: urlparams: {}
Line 1264: headers:
Line 1265: Content-Type: {value: application/xml|json, required: true}
Line 1266: Expect: {value: 201-created, required: false}
--
To view, visit http://gerrit.ovirt.org/10097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf39df28c5f87db4c1bf9b5807c45a0a8ea9a8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Alexey Chub <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
