Eli Mesika has posted comments on this change.

Change subject: core : API changes Multi-Tier fencing
......................................................................


Patch Set 5: (4 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1052:       </xs:extension>
Line 1053:     </xs:complexContent>
Line 1054:   </xs:complexType>
Line 1055: 
Line 1056:   <!-- Hosts -->
Done
Line 1057:   <xs:complexType name="Agent">
Line 1058:     <xs:sequence>
Line 1059:       <xs:element name="address" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1060:       <xs:element name="username" type="xs:string" minOccurs="0" 
maxOccurs="1"/>


Line 1058:     <xs:sequence>
Line 1059:       <xs:element name="address" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1060:       <xs:element name="username" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1061:       <xs:element name="password" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1062:       <xs:element name="options" type="Options" minOccurs="0"/>
Done
Line 1063:     </xs:sequence>
Line 1064:     <xs:attribute name="type" type="xs:string"/>
Line 1065:     <xs:attribute name="order" type="xs:int"/>
Line 1066:     <xs:attribute name="concurrent" type="xs:boolean"/>


Line 1062:       <xs:element name="options" type="Options" minOccurs="0"/>
Line 1063:     </xs:sequence>
Line 1064:     <xs:attribute name="type" type="xs:string"/>
Line 1065:     <xs:attribute name="order" type="xs:int"/>
Line 1066:     <xs:attribute name="concurrent" type="xs:boolean"/>
Done
Line 1067:   </xs:complexType>
Line 1068: 
Line 1069:   <xs:element name="agents" type="Agents"/>
Line 1070: 


....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 99:                 int order = 1;
Line 100:                 if (agent.isSetOrder()) {
Line 101:                     order = agent.getOrder();
Line 102:                 }
Line 103:                 if (order == 1) { // Primary
Done
Line 104:                     if (agent.isSetType()) {
Line 105:                         entity.setpm_type(agent.getType());
Line 106:                     }
Line 107:                     if (agent.isSetAddress()) {


--
To view, visit http://gerrit.ovirt.org/10262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad50a36b240043fc88a7f4f60ecfaee29c1e147f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to