Tal Nisan has posted comments on this change.
Change subject: core: Renamed bookmarks.java to Bookmark.java
......................................................................
Patch Set 5: Looks good to me, approved
(4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
Line 49: public String getbookmark_value() {
Line 50: return value;
Line 51: }
Line 52:
Line 53: public void setbookmark_value(String value) {
Here also, not a must but will be cool if you can change to:
setBookmarkValue
Line 54: this.value = value;
Line 55: OnPropertyChanged(new
PropertyChangedEventArgs("bookmark_value"));
Line 56:
Line 57: }
Line 56:
Line 57: }
Line 58:
Line 59:
Line 60: public void setbookmark_name(String name) {
Not a must for now, but for the rest of the methods and params I'd change the
methods and params to fit the convention, again, your choice if you want to do
it in this patch, if so:
setBookmarkName
Line 61: this.name = name;
Line 62: OnPropertyChanged(new
PropertyChangedEventArgs("bookmark_name"));
Line 63:
Line 64: }
Line 66:
Line 67: public Bookmark() {
Line 68: }
Line 69:
Line 70: public Bookmark(String bookmark_name, String bookmark_value) {
String bookmarkName, String bookmarkValue
Line 71: this.name = bookmark_name;
Line 72: this.value = bookmark_value;
Line 73:
Line 74: }
Line 73:
Line 74: }
Line 75:
Line 76: public Bookmark(String bookmark_name, String bookmark_value, Guid
bookmark_id) {
Line 77: this.name = bookmark_name;
String bookmarkName, String bookmarkValue, Guid bookmarkId
Line 78: this.value = bookmark_value;
Line 79: this.id = bookmark_id;
Line 80: }
Line 81:
--
To view, visit http://gerrit.ovirt.org/10049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I745cfd1a4e6184da098ee202a6134759fc62c52e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
