Liron Aravot has posted comments on this change.

Change subject: core : BLL changes for Multi-Tier fencing
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 301:             executor = new FencingExecutor(getVds(), 
FenceActionType.Status);
Line 302:             
fenceInvocationResult.setSucceeded(waitForStatus(getVds().getvds_name(), 
getParameters().getAction(), order));
Line 303:             }
Line 304:             finally {
Line 305:                 latch.countDown();
If we don't want to wait in case of START operation, can't we not use Future 
specifically to it but use Future for the other operations? we know what we 
want to execute
Line 306:             }
Line 307:         }
Line 308:         return fenceInvocationResult;
Line 309:     }


--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to