Moti Asayag has posted comments on this change. Change subject: core: Rename ad_groups class to LdapGroup ......................................................................
Patch Set 5: Tal, why not to split it into a series of patches ? Easier to review, verify and merge that way. If you agree with the current patch (as part of a wider series) - remove the -1. I think that the 'harder' part of the patch series is to get all acks for the 3 components where entities are used (backend, api, ui). Once the entity is renamed (and also public method names), it is simpler to send a following patches which are more granular which leads to faster review process. -- To view, visit http://gerrit.ovirt.org/9835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2429b55981a18cbb8fc9ceaf33d949195d66d8c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
