Mike Kolesnik has uploaded a new change for review. Change subject: engine: Union if statements ......................................................................
engine: Union if statements If statements were all doing the same thing, so unioned them into one statement. Change-Id: I16f319321dcf09a66cdfabb2bc122cbcfc1a260b Signed-off-by: Mike Kolesnik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java 1 file changed, 3 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/10466/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java index 67988a4..791d4e7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java @@ -51,15 +51,9 @@ protected boolean canDoAction() { List<VmNetworkInterface> interfaces = getVmNetworkInterfaceDao().getAllForTemplate(getParameters().getVmTemplateId()); - if (!interfaceNameUnique(interfaces)) { - return false; - } - - if (!validate(templateExists())) { - return false; - } - - if (!validate(linkedToTemplate())) { + if (!interfaceNameUnique(interfaces) + || !validate(templateExists()) + || !validate(linkedToTemplate())) { return false; } -- To view, visit http://gerrit.ovirt.org/10466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16f319321dcf09a66cdfabb2bc122cbcfc1a260b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
