Moti Asayag has posted comments on this change.
Change subject: engine: Fix networking commands warnings
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
Line 164: addCanDoActionMessage(String.format("$networks %1$s",
interfaceNetwork.getname()));
Line 165: return false;
Line 166: }
Line 167: }
Line 168:
a note for future patches:
replace !StringUtils.isEmpty with StringUtils.isNotEmpty
Line 169: if (!StringUtils.isEmpty(getMacAddress())) {
Line 170: if
(Pattern.matches(ValidationUtils.INVALID_NULLABLE_MAC_ADDRESS,
getMacAddress())) {
Line 171:
addCanDoActionMessage(VdcBllMessages.NETWORK_INVALID_MAC_ADDRESS);
Line 172: return false;
Line 167
Line 168
Line 169
Line 170
Line 171
it looks that we carried a bug all the time with this.
The current Regex.IsMatch implementation check only for a subsequence match and
not for the entire sequence.
--
To view, visit http://gerrit.ovirt.org/10461
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89af2a49e4d0f273bc4a784626e93b14d00806cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
