Liron Aravot has posted comments on this change.
Change subject: core: Adding support for completion service for ThreadPoolUtil
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java
Line 76: * execution results
Line 77: * @return
Line 78: */
Line 79: public static <V> ExecutorCompletionService<V>
createCompletionService() {
Line 80: ExecutorCompletionService<V> ecs = new
ExecutorCompletionService<V>(es);
you forgot to inline into one liner method as moti suggested on patch #1 .. :-)
other than that - looks good to me.
Line 81: return ecs;
Line 82: }
Line 83:
Line 84: /**
--
To view, visit http://gerrit.ovirt.org/10439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If806302ecf028a5db1c9726a407a1643b5c000b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
