Omer Frenkel has posted comments on this change.

Change subject: gluster: Fixed deadlock in nested command execution
......................................................................


Patch Set 1:

although this solution seems to work, i would like to suggest checking if using 
existing infrastructure wouldn't help,
it is possible to pass lock object between commands, its similar to this 
solution, just already implemented.
please check if you can use it, there is an example of usage in RunVmCommand, 
which call to create snapshots command, and pass lock object, as both need lock 
on the vm.

--
To view, visit http://gerrit.ovirt.org/10448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to