Eli Mesika has posted comments on this change.
Change subject: engine: enable payload with CDROM
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 142: // skip unamanged devices (handled separtely)
Line 143: if (!vmDevice.getIsManaged()) {
Line 144: continue;
Line 145: }
Line 146: boolean isPayload =
(VmPayload.isPayload(vmDevice.getSpecParams()) &&
Shahar, it seems to me more correct to encapsulate the payload code inside
addCdDetails
Line 147:
vmDevice.getDevice().equals(VmDeviceType.CDROM.getName()));
Line 148: struct = new XmlRpcStruct();
Line 149: String cdPath = vm.getCdPath();
Line 150: addCdDetails(vmDevice, struct);
--
To view, visit http://gerrit.ovirt.org/10422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1c1a4fc606f67cec90c803d13a052fab9ac1b7e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
