Vered Volansky has posted comments on this change.
Change subject: core: Fix error message when exporting to a non export domain
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 141:
Line 142: // check destination storage is Export domain
Line 143: if (getStorageDomain().getstorage_domain_type() !=
StorageDomainType.ImportExport) {
Line 144:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SPECIFY_DOMAIN_IS_NOT_EXPORT_DOMAIN);
Line 145: addCanDoActionMessage(String.format("$storageDomainName
%1$s", getStorageDomainName()));
Why not use failCanDoActionMessage()?
Line 146: return false;
Line 147: }
Line 148: // check destination storage have free space
Line 149: int sizeInGB = (int) getVm().getActualDiskWithSnapshotsSize();
--
To view, visit http://gerrit.ovirt.org/10498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe15389360d6233655056dcfd94880f8033b741
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
