Yair Zaslavsky has posted comments on this change. Change subject: [WIP] engine: User queries improvements ......................................................................
Patch Set 9: (3 inline comments) Followed Allon's comments .................................................... File backend/manager/dbscripts/create_functions.sql Line 42: Line 43: CREATE OR REPLACE FUNCTION fnSplitterUuid(ids TEXT) RETURNS SETOF UUID AS Line 44: $function$ Line 45: BEGIN Line 46: IF ids != '' THEN yes. just verified it is still necessary. Line 47: RETURN QUERY Line 48: SELECT CAST(regexp_split_to_table(ids, ',') AS UUID); Line 49: END IF; Line 50: END; $function$ .................................................... File backend/manager/dbscripts/create_views.sql Line 779: AS Line 780: Line 781: SELECT permissions.id as id, permissions.role_id as role_id, permissions.ad_element_id as ad_element_id, permissions.object_id as object_id, permissions.object_type_id as object_type_id, Line 782: roles.name as role_name, roles.role_type as role_type, roles.allows_viewing_children as allows_viewing_children Line 783: FROM permissions INNER JOIN Done Line 784: roles ON permissions.role_id = roles.id; Line 785: Line 786: Line 787: -- .................................................... Commit Message Line 7: [WIP] engine: User queries improvements Line 8: Line 9: The following patch contains two improvements: Line 10: 1. Removed unneeded calls to some functions at permissions_view, by creating the small_permissions_view - Line 11: permissions_view should be used for UI purposes , for engine/internal permission check, small_permissions_view should be used. Done Line 12: 2. Introduction of new splitter function. Line 13: Line 14: With multiple paragraphs if necessary. Line 15: -- To view, visit http://gerrit.ovirt.org/9825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
