Gilad Chaplik has posted comments on this change.
Change subject: userportal: Added caching to user portal page webadmin: Added
caching to webadmin page
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/CachingFilter.java
Line 55: // Cast to HttpServletRequest/Response.
Line 56: final HttpServletRequest httpRequest = (HttpServletRequest)
request;
Line 57: final HttpServletResponse httpResponse = (HttpServletResponse)
response;
Line 58:
Line 59: if (cacheFilterPatternMathes(httpRequest)) {
/s/Mathes/Matches
Line 60: HttpServletResponseWrapper responseWrapper =
getCacheHeaderResponseWrapper(httpResponse);
Line 61: httpResponse.setHeader(CACHE_CONTROL, CACHE_YEAR);
Line 62: httpResponse.setHeader(EXPIRES, getNowPlusYearHttpDate());
Line 63: chain.doFilter(request, responseWrapper);
....................................................
File
frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserportalDynamicHostingServlet.java
Line 7: /**
Line 8: * A landing servlet for UserPortal project.
Line 9: *
Line 10: * @author Asaf Shakarchi
Line 11: * @author Alexander Wels
authors?
Line 12: *
Line 13: */
Line 14: @WebServlet(name="UserPortalDynamicHosting",
value="/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html")
Line 15: public class UserportalDynamicHostingServlet extends
GwtDynamicHostPageServlet {
Line 25: protected void initQueryParams(VdcQueryParametersBase queryParams,
String sessionId) {
Line 26: super.initQueryParams(queryParams, sessionId);
Line 27:
Line 28: // All UserPortal queries are filtered according to user
permissions
Line 29: queryParams.setFiltered(true);
remove setFiltered in applicationInit.
I guess that we can wrap queryParams in server side (filtered and sessionId)
Line 30: }
Line 31:
--
To view, visit http://gerrit.ovirt.org/10449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8e02ae542a4aa37bd421bde5582c0f3e9820ad
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
