Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 813: logging.debug("%s DB Backup started", db)
Line 814:
Line 815: # Run backup
Line 816: db_backup = os.path.join(basedefs.DIR_DB_SCRIPTS,
Line 817: basedefs.FILE_DB_BACKUP_SCRIPT)
I think join can be inline the cmd... not that this important... but there is
no need for variables that are used only once.
Once I wrote that, there is no need for the join at all, as you execute this in
the dbscript directory, all you need it to join '.'.
Line 818: cmd = [
Line 819: db_backup,
Line 820: "-u", user,
Line 821: "-s", host,
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 275: os.remove(self.sqlfile)
Line 276:
Line 277: def backup(self):
Line 278: """
Line 279: Backup db using backup.sh
No need for method in comment.
Line 280: """
Line 281: # backup.sh -u postgres -f $file -d dbname -s server -p port
Line 282: utils.backupDB(
Line 283: db=basedefs.DB_NAME,
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 349
Line 350
Line 351
Line 352
Line 353
Not sure I understand why not calling the utils.backupDB directly.
--
To view, visit http://gerrit.ovirt.org/10548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
