Liron Aravot has posted comments on this change. Change subject: core: automatic reconstruct shouldn't abort user initiated recovery ......................................................................
Patch Set 1: Yair, as i described in this patch (see comments) http://gerrit.ovirt.org/#/c/9838/ with the even queue, a performedreconstruct cleans the whole queue, in case of no valid domains for reconstruct, it will run every few seconds and will do nothing. The user wants to provide an unattached domain to perform reconstruct to and have a valid pool again, in that case he is in a 'race' against the automatic initiated reconstruct that will be triggered every few seconds, which means that he will probably won't be able to submit the reconstruct with the new domain and recover from the situation... note: if reconstruct ran succesfully the recovery command shouldn't run, as it has a canDoAction check for the current master domain status : getStorageDomain().getstatus() == StorageDomainStatus.Active) { addInvalidSDStatusMessage(getStorageDomain().getstatus()); so in case of truly succesful reconstruct, the recovery shouldn't run anyway.. -- To view, visit http://gerrit.ovirt.org/10549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9423d880a7d10a5bfa917e415fe41651f9d7e7f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
