Mike Kolesnik has posted comments on this change.
Change subject: core: Standardize NetworkCluster
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java
Line 43: builder.append("NetworkCluster {id=")
Line 44: .append(getId())
Line 45: .append(", status=")
Line 46: .append(getstatus())
Line 47: .append(", isDisplay=")
should be just "display"
Line 48: .append(isDisplay())
Line 49: .append(", required=")
Line 50: .append(isRequired())
Line 51: .append("}");
Line 127: public void setNetworkId(Guid value) {
Line 128: id.setNetworkId(value);
Line 129: }
Line 130:
Line 131: public NetworkStatus getstatus() {
Don't you want to change this too?
Line 132: return this.status;
Line 133: }
Line 134:
Line 135: public void setStatus(NetworkStatus value) {
--
To view, visit http://gerrit.ovirt.org/10589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie96221377887185a759044710e098e56d83c6a94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
