Juan Hernandez has posted comments on this change.
Change subject: core: Locate data source in a loop
......................................................................
Patch Set 1: (2 inline comments)
> What about Backend.checkDBConnectivity? I don't like that the this code that
> has to do with db connectivity is scattered on two classes.
So what is your preference Yair? Move the data source location logic to the
Backend class? Or move the checkDBConnectivity logic to DbFacadeLocator?
In something has to be moved in my opinion all this code could be moved to the
DbFacade class, removing the DbFacadeLocator class, but that is probably out of
the scope of this change.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
Line 42: if (datasource != null) {
Line 43: break;
Line 44: }
Line 45:
Line 46: // Tell the user that the lookup failed but that we
will try
What treatment do you propose? Take into account that there is no way to
distinguish the case where the data source is not yet deployed from the case
where the the data source will never be deployed because of misconfiguration.
Line 47: // again in a few seconds:
Line 48: log.warn(
Line 49: "The datasource can't be located. This probably
means " +
Line 50: "that DNS is not working correctly or is slow,
please " +
Line 50: "that DNS is not working correctly or is slow,
please " +
Line 51: "check it. Will try again in a few seconds.");
Line 52:
Line 53: // Wait a bit before trying again:
Line 54: Thread.sleep(DEFAULT_INTERVAL_VALUE);
I don't think additional configuration for this is needed. But if you think it
is I will add it.
Line 55: }
Line 56:
Line 57: // Create the facade and return it:
Line 58: dbFacade = new DbFacade();
--
To view, visit http://gerrit.ovirt.org/10189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
