Michael Pasternak has uploaded a new change for review. Change subject: cli: Wrong error when passing empty collection based option #890525 ......................................................................
cli: Wrong error when passing empty collection based option #890525 https://bugzilla.redhat.com/show_bug.cgi?id=890525 Change-Id: I2be4471d69be581f3fded81780610d03a0907299 Signed-off-by: Michael Pasternak <[email protected]> --- M src/ovirtcli/command/command.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/79/10679/1 diff --git a/src/ovirtcli/command/command.py b/src/ovirtcli/command/command.py index e9a7da8..1ae497a 100644 --- a/src/ovirtcli/command/command.py +++ b/src/ovirtcli/command/command.py @@ -113,6 +113,10 @@ root_obj_params_set_cand = obj_params_set_cand else: self.error(Messages.Error.NO_SUCH_TYPE) % props[i] + + if not val: + self.error(Messages.Error.INVALID_COLLECTION_BASED_OPTION_SYNTAX % prop) + for param in val.split(','): obj_params_set_cand = root_obj_params_set_cand param_data = param.replace(props[i] + '.', '').split('=') -- To view, visit http://gerrit.ovirt.org/10679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2be4471d69be581f3fded81780610d03a0907299 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
