Maor Lipchuk has posted comments on this change.
Change subject: core:StorageHelper cleanup, code clean
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
Line 36: if (pool.getspm_vds_id() == null) {
Line 37: log.errorFormat("Pool {0} does not have spm vds id to
connect storage to domain.", pool.getname());
Line 38: return false;
Line 39: }
Line 40: return runConnectionStorageToDomain(storageDomain,
pool.getspm_vds_id().getValue(), type);
This should not happened. storage pool with no VDS should be null and not empty
GUID
Line 41: }
Line 42:
Line 43: @Override
Line 44: public boolean
disconnectStorageFromDomainByStoragePoolId(storage_domains storageDomain, Guid
storagePoolId) {
....................................................
Commit Message
Line 5: CommitDate: 2012-12-27 17:53:15 +0200
Line 6:
Line 7: core:StorageHelper cleanup, code clean
Line 8:
Line 9: Refactor implementation of runForSingleConnectionInHost to be more short
Done
Line 10: and readable
Line 11:
Line 12: Change-Id: Ica461c6d592932a061472bf87e47e6bfa0687e3d
--
To view, visit http://gerrit.ovirt.org/10140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica461c6d592932a061472bf87e47e6bfa0687e3d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
