Gilad Chaplik has posted comments on this change.

Change subject: core: rerun HA vm that fails during live snapshot
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 185:     }
Line 186: 
Line 187:     private boolean isVmDownUnexpectedly() {
Line 188:         VM vm = getVmDAO().get(getVmId());
Line 189:         return ImagesHandler.isVmDown(vm) && vm.getExitStatus() != 
VmExitStatus.Normal;
first perform the enum comparison
Line 190:     }
Line 191: 
Line 192:     private boolean wasVmUpInitially() {
Line 193:         VMStatus vmStatus = getParameters().getInitialVmStatus();


--
To view, visit http://gerrit.ovirt.org/10618
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5daeffd1cee106019065c29fb8428a9b9f78a5d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to