Omer Frenkel has posted comments on this change.
Change subject: core: Make connection timeout configurable
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 516: select fn_db_add_config_value('VdcVersion','3.0.0.0','general');
Line 517: select
fn_db_add_config_value('VDSAttemptsToResetCount','2','general');
Line 518: select
fn_db_add_config_value('VdsCertificateValidityInYears','5','general');
Line 519: select fn_db_add_config_value('vdsConnectionTimeout','180','3.0');
Line 520: select fn_db_add_config_value('vdsConnectionTimeout','180','3.1');
since some time has passed, there is now support for 3.2 cluster as well,
please add relevant values for it
Line 521: select
fn_db_add_config_value('VdsFenceOptionMapping','alom:secure=secure,port=ipport;apc:secure=secure,port=ipport,slot=port;bladecenter:secure=secure,port=ipport,slot=port;drac5:secure=secure,port=ipport;eps:slot=port;ilo:secure=ssl,port=ipport;ipmilan:;rsa:secure=secure,port=ipport;rsb:;wti:secure=secure,port=ipport,slot=port;cisco_ucs:secure=ssl,slot=port','general');
Line 522: select fn_db_add_config_value('VdsFenceOptions','','general');
Line 523: select
fn_db_add_config_value('VdsFenceOptionTypes','secure=bool,port=int,slot=int','general');
Line 524: select
fn_db_add_config_value('VdsFenceType','alom,apc,bladecenter,drac5,eps,ilo,ipmilan,rsa,rsb,wti,cisco_ucs','2.2');
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 547:
Line 548: if (host != null) {
Line 549: // Get the compatibility version of the
cluster, as the values of the
Line 550: // timeouts used depend on that:
Line 551: String clusterVersion =
Config.DefaultConfigurationVersion;
maybe its better to use the storage-pool competability version instead of some
default, i think will be better choice.
Line 552: if (mCurrentVdsId != null) {
Line 553: VDS vds =
DbFacade.getInstance().getVdsDao().get(mCurrentVdsId);
Line 554: if (vds != null) {
Line 555: clusterVersion =
vds.getvds_group_compatibility_version().getValue();
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 178: // timeouts used depend on that:
Line 179: String clusterVersion =
_vds.getvds_group_compatibility_version().getValue();
Line 180:
Line 181: // Find the version specific timeouts:
Line 182: int clientTimeOut = Config.<Integer>
GetValue(ConfigValues.vdsTimeout, clusterVersion) * 1000;
i didn't see change in the config.sql to make this value per-version, so it's
not ok to call it with version if its 'general' config
Line 183: int connectionTimeOut =
Config.<Integer>GetValue(ConfigValues.vdsConnectionTimeout, clusterVersion) *
1000;
Line 184: int clientRetries =
Config.<Integer>GetValue(ConfigValues.vdsRetries, clusterVersion);
Line 185:
Line 186: Pair<VdsServerConnector, HttpClient> returnValue =
--
To view, visit http://gerrit.ovirt.org/8410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a49ae5d655c2105c5840decec81ae712e40c32
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
