Omer Frenkel has posted comments on this change.
Change subject: engine: vmstatic and vmbase cleanup
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
Line 202: public boolean isFirstRun() {
Line 203: return !isInitialized();
Line 204: }
Line 205:
Line 206: public String getVmName() {
probably not for this patch, (same as the comments on vmtGuid) this should be
just get(/set)Name - and moved to VmBase
Line 207: return this.name;
Line 208: }
Line 209:
Line 210: public void setVmName(String value) {
--
To view, visit http://gerrit.ovirt.org/9824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b75b583819587b53cd33124d5536d4e114d3494
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
