Frank Kobzik has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
......................................................................
Patch Set 1: (2 inline comments)
First patchset.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleActionGroupsByUserIdQuery.java
Line 20: @Override
Line 21: protected void executeQueryCommand() {
Line 22: NGuid userId = getParameters().getUserId();
Line 23:
Line 24: List <permissions> permissions =
getDbFacade().getPermissionDao().getAllForAdElement(userId.getValue());
This will not work for admin@internal user, I suppose. I need to fix this.
Line 25: List<ActionGroup> result = new ArrayList<ActionGroup>();
Line 26: for (permissions permission : permissions) {
Line 27: Guid roleId = permission.getrole_id();
Line 28: List<ActionGroup> actionGroups =
getDbFacade().getActionGroupDao().getAllForRole(roleId);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 203: * Executes given command. The confirmation dialog is displayed
when it's
Line 204: * not safe to take over the console.
Line 205: *
Line 206: * @param command
Line 207: */
The reason for method not to check the conditions and simply return boolean is
that one of the checks is async.
Line 208: protected void executeCommandWithConsoleSafenessWarning(final
UICommand command) {
Line 209: VM vm = getEntity();
Line 210: if (vm.getAllowConsoleReconnect() || vm.getConsoleUserId() ==
null ||
Line 211:
vm.getConsoleUserId().equals(Frontend.getLoggedInUser().getUserId())) {
--
To view, visit http://gerrit.ovirt.org/10770
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
