Juan Hernandez has posted comments on this change.
Change subject: core: Added DocsServlet core: Added SplashServlet webadmin:
Added handling missing languages webadmin: Added handling missing languages
......................................................................
Patch Set 9: (6 inline comments)
....................................................
File backend/manager/modules/root/pom.xml
Line 71: <version>${mockito.version}</version>
Line 72: <scope>test</scope>
Line 73: </dependency>
Line 74: <dependency>
Line 75: <groupId>commons-logging</groupId>
I think that we already have commons-logging as a dependency in the root POM,
but not in the dependenciesManagement section. Can we put this there instead of
here?
Line 76: <artifactId>commons-logging</artifactId>
Line 77: <version>1.1</version>
Line 78: <exclusions>
Line 79: <exclusion> <!-- declare the exclusion here -->
Line 75: <groupId>commons-logging</groupId>
Line 76: <artifactId>commons-logging</artifactId>
Line 77: <version>1.1</version>
Line 78: <exclusions>
Line 79: <exclusion> <!-- declare the exclusion here -->
This comment is a leftover from copy & paste, I guess.
Line 80: <groupId>javax.servlet</groupId>
Line 81: <artifactId>servlet-api</artifactId>
Line 82: </exclusion>
Line 83: </exclusions>
....................................................
File
backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/languages.properties
Line 1: #Available languages
Line 2: en_US=English
If English start with upper case shouldn't the others as well?
Line 3: fr=français
Line 4: es=español
Line 5: ja=\u65E5\u672C\u8A9E
Line 6: pt_BR=português do Brasil
....................................................
File backend/manager/modules/root/src/main/webapp/style.css
Line 93: }
Line 94:
Line 95: /*The locale selection box.*/
Line 96: .locale_select_panel {
Line 97: background:
url("/webadmin/webadmin/images/triangle_down_gray.gif") no-repeat scroll right
center;
This introduces a dependency on webadmin that I would like to avoid. I mean,
this will not work if webadmin is not installed. I know that it is not likely,
but may happen. Can make a copy of the .gif instead?
Line 98: float: right;
Line 99: margin-left: 270px;
Line 100: margin-right: 25px;
Line 101: margin-top: 10px;
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java
Line 29: result = Locale.US;
Line 30: }
Line 31: }
Line 32: catch(IllegalArgumentException e) {
Line 33: result = returnDefaultLocale ? Locale.US : null;
We could send a log message, something like "Can't find locale XXX.".
Line 34: }
Line 35: return result;
Line 36: }
....................................................
Commit Message
Line 6:
Line 7: core: Added DocsServlet
Line 8: core: Added SplashServlet
Line 9: webadmin: Added handling missing languages
Line 10: webadmin: Added handling missing languages
This sugggest three different changes, and the last one is repeated.
Line 11:
Line 12: - Added DocsServlet to automatically redirect users if
Line 13: the servlet cannot find the documentation in the users locale.
Line 14: - Added a check to make sure we are being passed a valid locale.
--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
