Gilad Chaplik has posted comments on this change.
Change subject: userportal: Optimize basic view
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
Line 423: }
Line 424:
Line 425: public boolean entityStateEqualTo(UserPortalItemModel other) {
Line 426: if (getEntity() instanceof vm_pools && other.getEntity()
instanceof vm_pools) {
Line 427: return getStatus() == other.getStatus();
we need to use equals
see the note about 2 vm_pools members that always get refresh (IMHO should be
checked only in backend side).
Line 428: }
Line 429:
Line 430: else if (getEntity() instanceof VM && other.getEntity()
instanceof VM) {
Line 431: VM thisVm = (VM) getEntity();
Line 430: else if (getEntity() instanceof VM && other.getEntity()
instanceof VM) {
Line 431: VM thisVm = (VM) getEntity();
Line 432: VM otherVm = (VM) other.getEntity();
Line 433: return thisVm.getStatus() == otherVm.getStatus()
Line 434: && thisVm.getVmName().equals(otherVm.getVmName());
we need to use equals on VmStatic and check status (vmDynamic)
Line 435: }
Line 436:
Line 437: return false;
Line 438: }
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
