Alon Bar-Lev has posted comments on this change. Change subject: packaging: Use temporary modules directory ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) I still think that we should not hide jboss issues, and better to fix them at jboss project than workaround them in our project. But this patch is better than actually remove files that do not belong to us. .................................................... File packaging/fedora/engine-service.py Line 420: engineModulesDir = os.path.join(engineUsrDir, "modules") Line 421: Line 422: # Link all the JBoss modules into a temporary directory: Line 423: jbossModulesTmpDir = os.path.join(engineTmpDir, "modules") Line 424: if not os.path.exists(jbossModulesTmpDir): I think we should remove the directory first. Also we can use mkdirs at the function so no need to make anything here. Line 425: os.mkdir(jbossModulesTmpDir) Line 426: linkModules(jbossModulesDir, jbossModulesTmpDir) Line 427: Line 428: # Module path should include first the engine modules so that they can override -- To view, visit http://gerrit.ovirt.org/10292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f27390a232df42b477dc0e9abe7909e10d9abb1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
