Alissa Bonas has posted comments on this change.
Change subject: core: add isDebugEnabled to Log class
......................................................................
Patch Set 1:
Usually what happens in many production environments is either they are
configured at ERROR loglevel at everyday activity, or if there is a problem
they are switched to DEBUG.
The debug messages are the most frequent ones, and if they contain string
concatination/expensive calculation/loading resources/etc- they can decrease
performance.
Info messages by nature are less frequent and their impact on performance is
minor so they are less important to have a guard statement.
You can also see in the same Log class that the method debugFormat has a guard
statement ("if...Enabled"), however infoFormat doesn't.
--
To view, visit http://gerrit.ovirt.org/10806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14598886a3b9269d0a9b4b04febee0aa0f2eec98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
