Juan Hernandez has posted comments on this change.
Change subject: packaging: Add compression for all logs.
......................................................................
Patch Set 2: (3 inline comments)
Why not *.log.* as you had in the previous patch set?
....................................................
File packaging/resources/ovirtlogrot.sh
Line 10: dateformat="+%Y%m%d_%H"
Line 11:
Line 12: date=`date $dateformat`
Line 13:
Line 14: for i in `ls $logdir/engine.log.* $logdir/server.log.*
$logdir/jasperserver.log.* -t`; do
What about $logdir/{engine,server,jasperserver}.log.*?
Line 15: m=`expr match $i .*gz`
Line 16: if [ $m == 0 ]
Line 17: then
Line 18: cat $i | gzip -9 > $i-$date.gz && rm $i
Line 23: # remove the old logs
Line 24: #
Line 25:
Line 26: lastlogday=`date -d "$maxage hours ago" $dateformat`
Line 27: for i in `ls $logdir/engine.log.*.gz $logdir/server.log.*.gz
$logdir/jasperserver.log.*.gz`; do
Same {...} here.
Line 28: timestamp=`echo $i | sed s/.*-// | sed s/\.gz//`
Line 29: if [[ "$lastlogday" > "$timestamp" ]]
Line 30: then
Line 31: rm -f $logdir/engine.log.*$timestamp.gz
$logdir/server.log.*$timestamp.gz $logdir/jasperserver.log.*$timestamp.gz
Line 27: for i in `ls $logdir/engine.log.*.gz $logdir/server.log.*.gz
$logdir/jasperserver.log.*.gz`; do
Line 28: timestamp=`echo $i | sed s/.*-// | sed s/\.gz//`
Line 29: if [[ "$lastlogday" > "$timestamp" ]]
Line 30: then
Line 31: rm -f $logdir/engine.log.*$timestamp.gz
$logdir/server.log.*$timestamp.gz $logdir/jasperserver.log.*$timestamp.gz
And here.
Line 32: fi
--
To view, visit http://gerrit.ovirt.org/10811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0714f421c6d5b42b25f4a6c6d905cd00eb5baed3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
