Moti Asayag has posted comments on this change.
Change subject: core: add toString method to VM and VDS
......................................................................
Patch Set 6: (2 inline comments)
Generally, i think that for debug purpose sometimes the ID can be helpful as
well.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 1330: }
Line 1331:
Line 1332: @Override
Line 1333: public String toString() {
Line 1334: return "VDS[" + (mVdsStatic == null ? "null" :
mVdsStatic.gethost_name()) + "]";
maybe Host[...] instead of VDS[...] ?
Note that you can also use getName() to obtain the host name.
Line 1335: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1513: }
Line 1514:
Line 1515: @Override
Line 1516: public String toString() {
Line 1517: return "VM [" + vmStatic.getvm_name() + "]";
you can use getName() instead of vmStatic.getvm_name()
Line 1518: }
--
To view, visit http://gerrit.ovirt.org/7640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd449b18c6187d00366e2c30d4288c909a9ef6a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
