Yaniv Kaul has posted comments on this change. Change subject: packaging: Change the timestamp of log rotation. ......................................................................
Patch Set 4: (2 inline comments) The patch is incorrect. Please test and tell me if they have different timestamps now. .................................................... File packaging/resources/ovirtlogrot.sh Line 6: # Line 7: Line 8: logdir=$1 Line 9: maxage=$2 Line 10: dateformat="+%Y%m%d_%H%M%S" That will still make all logs to have the same timestamp, only with minutes and seconds. Line 11: Line 12: date=`date $dateformat` Line 13: Line 14: for i in `ls $logdir/engine.log.* -t`; do Line 14: for i in `ls $logdir/engine.log.* -t`; do Line 15: m=`expr match $i .*gz` Line 16: if [ $m == 0 ] Line 17: then Line 18: cat $i | gzip -9 > $i-$date.gz && rm $i You could have set the date here, but that would still be pretty much similar. You need to take the date and time of the file and append to the name, if you want to make it a bit more useful. In any case, the patch is not correct as is. Line 19: fi Line 20: done; Line 21: Line 22: # -- To view, visit http://gerrit.ovirt.org/10810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d115f9ade4bd49245f4b26e7d96b8df582d110c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
