Roy Golan has posted comments on this change.
Change subject: core: add "disabled" feature to template
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
minor - see inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 289:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_DOES_NOT_EXIST);
Line 290: return false;
Line 291: }
Line 292: if (getVmTemplate().isDisabled()) {
Line 293:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_IS_DISABLED);
minor - can you use
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_IS_DISABLE) method
here?
Line 294: return false;
Line 295: }
Line 296: returnValue = buildAndCheckDestStorageDomains();
Line 297: if (returnValue) {
--
To view, visit http://gerrit.ovirt.org/10502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f8b60280d76b73a26f0d5feaf6650c7ef7ce7e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
