Liron Aravot has posted comments on this change. Change subject: core: Move status check methods from VM to VMStatus ......................................................................
Patch Set 1: VMStatus is an enum, i don't think that it should contain logic regarding migration for example, I don't see why this should be contained here. "simple" checks can be checked directly by the enum value, but more complex one should be in VmHandler in my opinion. the purpose of this enum is just to contain value to represent the vm status, not to contain logic and "know" about system flows. -- To view, visit http://gerrit.ovirt.org/10795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
