Sharad Mishra has posted comments on this change.
Change subject: webadmin: WIP: Create storage domains using Gluster FS.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 384: item = PreparePosixStorageForEdit(storage);
Line 385: break;
Line 386:
Line 387: case GLUSTERFS:
Line 388: item = PrepareGlusterStorageForEdit(storage);
I agree. Will change the name.
Line 389: break;
Line 390: }
Line 391:
Line 392: model.setItems(new ArrayList<IStorageModel>(Arrays.asList(new
IStorageModel[] {item})));
Line 1298: parameters,
Line 1299: new
ArrayList<IFrontendActionAsyncCallback>(Arrays.asList(new
IFrontendActionAsyncCallback[] {
Line 1300: callback1, callback2 })),
Line 1301: failureCallback,
Line 1302: this);
It is very similar. I can make the changes based on community decision. Do all
agree that we should try to combine the two?
Line 1303: }
Line 1304:
Line 1305: private void SaveGlusterStorage(TaskContext context) {
Line 1306:
--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74870ea95a103ecdd228a26d314ff66e2fcc675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
