Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File src/engine-iso-uploader.py
Line 413: if self.configuration.get("insecure"):
Line 414: params["insecure"] = True
Line 415: # Otherwise, use ca_file
Line 416: else:
Line 417: params["ca_file"] =
self.configuration.get("engine_ca")
We're trying to solve the issue in the API. It will check the presence of the
"ca_file" param, and if it is present, it will ignore the "insecure" parameter.
I can't see other way to solve it without "fixing" API.
Line 418:
Line 419: # Create an API object
Line 420: self.api = API(**params)
Line 421:
Line 416: else:
Line 417: params["ca_file"] =
self.configuration.get("engine_ca")
Line 418:
Line 419: # Create an API object
Line 420: self.api = API(**params)
That won't work. As soon as ca_file parameter is provided, SDK ignores
"insecure" flag.
Line 421:
Line 422: pi = self.api.get_product_info()
Line 423: if pi is not None:
Line 424: vrm = '%s.%s.%s' % (
--
To view, visit http://gerrit.ovirt.org/10815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
