Doron Fediuck has posted comments on this change. Change subject: Different log message for graceful shotdown ......................................................................
Patch Set 1: In most cases I prefer to separate refactor from the actual fix. This would be such a case. Also, nested condition can be done much simpler with setting default values, and the relevant values only in the condition block. Next, call the method you need once. -- To view, visit http://gerrit.ovirt.org/10875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I409f335fd98959aab4bc1633191a853777b050fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
