Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: A check for possible NPE in
NicActivateStatusColumn:getTooltip
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java
Line 51: tooltip =
Line 52:
tooltip.append(templates.cardStatus(constants.unpluggedNetworkInteface()).asString());
Line 53: }
Line 54:
Line 55: tooltip = tooltip.append("<BR>"); //$NON-NLS-1$
which condition? isLinked is a primitive boolean,
Anyway this 'bug' is a findbug issue that needs to be cleaned.
Line 56: if (vnic.isLinked()) {
Line 57: tooltip =
Line 58:
tooltip.append(templates.linkState(constants.linkedNetworkInteface())
Line 59: .asString());
--
To view, visit http://gerrit.ovirt.org/10957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib350579b4ff7d7193a9870c83f4014df57bb3da4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
