Shireesh Anjal has posted comments on this change.
Change subject: gluster: Log details of option being set
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java
Line 29: public Map<String, String> getCustomValues() {
Line 30: AddCustomValue(GlusterConstants.OPTION_KEY,
getParameters().getVolumeOption().getKey());
Line 31: AddCustomValue(GlusterConstants.OPTION_VALUE,
getParameters().getVolumeOption().getValue());
Line 32: return super.getCustomValues();
Line 33: }
No - AFAIK there are no such confidential details that one would like to avoid
from the audit log. In fact, an audit log message that just says "option was
set" is of no use at all, unless we include what option was set to what value.
Am adding Vijay as reviewer to confirm just this point.
Line 34:
Line 35: @Override
Line 36: protected void setActionMessageParameters() {
Line 37: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__SET);
....................................................
Commit Message
Line 5: CommitDate: 2013-01-11 21:06:47 +0530
Line 6:
Line 7: gluster: Log details of option being set
Line 8:
Line 9: Midified the audit log message for setting a volume option
thanks :) will change.
Line 10: to include the key and value of the option, so that user
Line 11: knows exactly what option was set to what value.
Line 12:
Line 13: Change-Id: I7c5b4712128056a4ba5f1d87cf8fd9114f95116b
--
To view, visit http://gerrit.ovirt.org/10908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c5b4712128056a4ba5f1d87cf8fd9114f95116b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vijay Bellur <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
